Skip to content

feat(client-presence): Expose Presence at Workspaces and State objects #24396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 21, 2025
Merged

feat(client-presence): Expose Presence at Workspaces and State objects #24396

merged 13 commits into from
Apr 21, 2025

Conversation

WillieHabi
Copy link
Contributor

@WillieHabi WillieHabi commented Apr 17, 2025 •
edited
Loading

Description

This change passes down and exposes presence at Workspace (StatesWorkspace.presence and NotificationsWorkspace.presence) and State objects (Latest.presence, LatestMap.presence, and NotificationsManager.presence).

@github-actions github-actions bot added area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct changeset-present public api change Changes to a public API base: main PRs targeted against main branch labels Apr 17, 2025
jason-ha
jason-ha reviewed Apr 18, 2025
View reviewed changes
@jason-ha jason-ha changed the title refactor(client-presence): Expose root Presence object to workspace and value manager level feat(client-presence): Expose Presence from Workspaces and State objects Apr 18, 2025
@jason-ha jason-ha changed the title feat(client-presence): Expose Presence from Workspaces and State objects feat(client-presence): Expose Presence at Workspaces and State objects Apr 18, 2025
@WillieHabi WillieHabi requested a review from jason-ha April 18, 2025 19:52
@WillieHabi WillieHabi marked this pull request as ready for review April 18, 2025 19:52
@WillieHabi WillieHabi requested a review from a team as a code owner April 18, 2025 19:52
jason-ha
jason-ha reviewed Apr 18, 2025
View reviewed changes
Copy link
Contributor

@jason-ha jason-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small requests :)

WillieHabi and others added 3 commits April 18, 2025 22:36
jason-ha
jason-ha reviewed Apr 18, 2025
View reviewed changes
jason-ha
jason-ha reviewed Apr 18, 2025
View reviewed changes
Copy link
Contributor

@jason-ha jason-ha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some dangling cleanup from before still needed

@WillieHabi WillieHabi requested a review from jason-ha April 18, 2025 22:12
tylerbutler
tylerbutler approved these changes Apr 21, 2025
View reviewed changes
Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs. Please see comments.

@WillieHabi @tylerbutler
Update .changeset/giant-news-appear.md
d1397d5 
Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
@WillieHabi @tylerbutler
Update .changeset/giant-news-appear.md
d4860f0 
Co-authored-by: Tyler Butler <tyler@tylerbutler.com>
@github-actions GitHub Actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  163664 links
    1315 destination URLs
    1547 URLs ignored
       0 warnings
       0 errors

@WillieHabi WillieHabi merged commit c056567 into microsoft:main Apr 21, 2025
38 checks passed
This was referenced Apr 21, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-ha jason-ha jason-ha approved these changes

@tylerbutler tylerbutler Awaiting requested review from tylerbutler

Assignees
No one assigned
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WillieHabi @tylerbutler @jason-ha